On Tuesday 28 October 2008, Guillaume Pothier wrote: > to have the corona register itself when created. Ok to commit?
getting closer =) first, the patch needs to guard against containment() and/or corona() being 0. doing dynamic_casts like this: menu.exec(dynamic_cast<Plasma::Corona*>(scene())->popupPosition(this, menu.size())); isn't useful because dynamic_cast can return 0; if you aren't checking the return value, then just do a static_cast. in any case, it really ought to be like: Plasma::Corona *c = m_applet->corona(); menu.exec(c ? c->popupPosition(this, menu.size()) : e->screenPos()); also Corona::screenGeometry should have a Q_UNUSED(id) to avoid a compiler warning. so, some small implementation fixes, but i like how simple this makes things while removing QDesktopWidget use from libplasma. after the above changes are made, pls commit. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
