On Monday 27 October 2008, Guillaume Pothier wrote: > 2008/10/27 Aaron J. Seigo <[EMAIL PROTECTED]>: > >> The latter should probably return a QRegion instead, according to what > >> you said about toolbox placement. > > > > yes, it should be a QRegion. > > ok, I'll use QRegion in the API, but for now the region will be > rectangular and the toolbox positioning code will rely on the region's > bounding box. Later I'll see how to improve that. Is that ok?
absolutely. it's a good pragmatic "one step at a time" approach > >> - Added a ViewerCorona class to plasmoidviewer, as Plasma::Corona is > >> now has pure virtual methods. > > > > shouldn't be necessary if they aren't pure virtual. that you had to do > > this work was probably a good hint something could be better =) > > I think plasmoidviewer needs its own corona anyway so as to report the > actual window size instead of a meaningless value? no; it should just set the sceneRect to be equal to the window size. i'm pretty sure it already does that, actually. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
