kpumuk commented on code in PR #3634: URL: https://github.com/apache/thrift/pull/3634#discussion_r3566559290
########## test/rb/Gemfile: ########## @@ -5,10 +5,19 @@ source "https://rubygems.org"; gem 'thrift', path: '../../lib/rb' gem 'rack', '~> 2.2', '>= 2.2.23' +gem 'puma', '~> 6.6' gem 'test-unit', '~> 3.2', '>= 3.2.7' +# Only required for tests with Rack 2.x on Ruby 4.0+ +gem 'cgi' +gem 'ostruct' + group :thin_http_server do gem 'thin', '~> 1.7', '>= 1.7.2' end +group :falcon_http_server, optional: true do + gem 'falcon', '~> 0.51' +end Review Comment: This suggestion will lead to weird discrepancies in the lock file, so no, rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
