aglinxinyuan commented on PR #4342: URL: https://github.com/apache/texera/pull/4342#issuecomment-4228269248
> I know the PR was already merged. Sorry for chiming in later. > > > > I prefer to treat formatting changes in a separate PR, and only keep logical changes in this PR. @aglinxinyuan Do you agree? That’s not the practice we were following in the past. We usually make minor fixes like formatting along with major changes in a single PR. Of course, it is possible to make every single line of change a separate PR, and they would still be logically correct, but it would dramatically decrease productivity. Since I’m touching those files, I feel it makes sense for me to improve some formatting issues I’ve seen in the same file. Of course, I don’t have to do that, and it doesn’t make much sense to create a separate PR just for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
