aglinxinyuan commented on code in PR #4342:
URL: https://github.com/apache/texera/pull/4342#discussion_r3067785827
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/dummy/DummyOpDesc.scala:
##########
@@ -39,12 +39,12 @@ class DummyOpDesc extends LogicalOp with PortDescriptor {
InputPort(
PortIdentity(idx),
displayName = portDesc.displayName,
- allowMultiLinks = portDesc.allowMultiInputs,
+ disallowMultiLinks = portDesc.disallowMultiInputs,
dependencies = portDesc.dependencies.map(idx => PortIdentity(idx))
)
}
} else {
- List(InputPort(PortIdentity(), allowMultiLinks = true))
Review Comment:
`InputPort()` defaults to `InputPort(PortIdentity())`, which is equivalent
to `InputPort(PortIdentity(0))`.
We use `InputPort()` consistently elsewhere; the only reason
`PortIdentity()` was previously passed here was to explicitly set the
positional argument.
<img width="1930" height="206" alt="image"
src="https://github.com/user-attachments/assets/647b121c-6744-4553-94c9-a6a50cf5471f";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
