Yicong-Huang commented on PR #4342: URL: https://github.com/apache/texera/pull/4342#issuecomment-4227647959
> > I left some comments. @aglinxinyuan please add some more description on the PR itself, so we know the changes in high level. > > I find many unexpected changes, in my opinion they should not be in this PR, according to the current description. @chenlica please chime in on review process. > > All the changes are intentional expect one line. That line is also a placeholder so it has no effect on the codebase. All the changes in the PR are being discussed and reviewed. Every reviewer has different standards, so it's very subjective. Please minimize the change. even if a change has no "big effect" it should be avoided, if it is unrelated to the PR's scope. Not to mention there is indeed unintentional change included in the PR that should not have been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
