Yicong-Huang commented on code in PR #4342:
URL: https://github.com/apache/texera/pull/4342#discussion_r3067329631
##########
common/config/src/main/resources/storage.conf:
##########
@@ -43,10 +43,10 @@ storage {
uri-without-scheme = "localhost:5432/texera_iceberg_catalog"
uri-without-scheme =
${?STORAGE_ICEBERG_CATALOG_POSTGRES_URI_WITHOUT_SCHEME}
- username = "texera"
Review Comment:
we should avoid this kind of unintentional change. whether it has effect or
not is debatable. for example, for other developers they may have conflict when
they pull the change that they need to deal with. so that's also "effect".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
