Yicong-Huang commented on code in PR #4342:
URL: https://github.com/apache/texera/pull/4342#discussion_r3067251107
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/visualization/bulletChart/BulletChartOpDesc.scala:
##########
@@ -57,7 +58,7 @@ class BulletChartOpDesc extends PythonOperatorDescriptor {
@JsonProperty(value = "steps", required = false)
@JsonSchemaTitle("Steps")
@JsonPropertyDescription("Optional: Each step includes a start and end value
e.g., 0, 100.")
- var steps: JList[BulletChartStepDefinition] = new
ArrayList[BulletChartStepDefinition]()
+ var steps: JList[BulletChartStepDefinition] = new
util.ArrayList[BulletChartStepDefinition]()
Review Comment:
why this change?
##########
common/config/src/main/resources/storage.conf:
##########
@@ -43,10 +43,10 @@ storage {
uri-without-scheme = "localhost:5432/texera_iceberg_catalog"
uri-without-scheme =
${?STORAGE_ICEBERG_CATALOG_POSTGRES_URI_WITHOUT_SCHEME}
- username = "texera"
Review Comment:
@aglinxinyuan @Xiao-zhen-Liu are these changes intentional? it is not
mentioned in PR description.
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/dummy/DummyOpDesc.scala:
##########
@@ -39,12 +39,12 @@ class DummyOpDesc extends LogicalOp with PortDescriptor {
InputPort(
PortIdentity(idx),
displayName = portDesc.displayName,
- allowMultiLinks = portDesc.allowMultiInputs,
+ disallowMultiLinks = portDesc.disallowMultiInputs,
dependencies = portDesc.dependencies.map(idx => PortIdentity(idx))
)
}
} else {
- List(InputPort(PortIdentity(), allowMultiLinks = true))
Review Comment:
I think we need to keep the PortIdentity() part. `PortIdentity()` returns
`PortIdentity(0)`.
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/visualization/bubbleChart/BubbleChartOpDesc.scala:
##########
@@ -85,12 +85,10 @@ class BubbleChartOpDesc extends PythonOperatorDescriptor {
}
override def operatorInfo: OperatorInfo =
- OperatorInfo(
+ OperatorInfo.forVisualization(
"Bubble Chart",
"a 3D Scatter Plot; Bubbles are graphed using x and y labels, and their
sizes determined by a z-value.",
- OperatorGroupConstants.VISUALIZATION_BASIC_GROUP,
- inputPorts = List(InputPort()),
- outputPorts = List(OutputPort(mode = OutputMode.SINGLE_SNAPSHOT))
Review Comment:
why do we have those changes on the output port? I thought the PR is only
about input port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
