amaannawab923 commented on code in PR #33054:
URL: https://github.com/apache/superset/pull/33054#discussion_r2044434476
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx:
##########
@@ -118,9 +120,23 @@ const VerticalFormItem = styled(StyledFormItem)`
}
}
}
+
+ .ant-form-item-control-input-content {
+ ${({ inverseSelection }) => inverseSelection && 'display: flex;'}
Review Comment:
That is likely difficult due to the structure of the Native filter
The FilterControl.tsx has the label and the SelectFilterPlugin has the
Select dropdown
<div>
<FormItem
label={label}
htmlFor={filter.id}
required={filter?.controlValues?.enableEmptyFilter}
validateStatus={validateStatus}
>
<OutPortal node={portalNode} />
</FormItem>
</div>
The filter control is rendering these Selects through portals ....
I would have placed everything here in FilterControl only
<div>
<FormItem
label={label}
htmlFor={filter.id}
required={filter?.controlValues?.enableEmptyFilter}
validateStatus={validateStatus}
>
<OutPortal node={portalNode} /> <-
<ExcludeFilterValues />
</FormItem>
</div>
But cant since the SelectFilterPlugin is getting rendered through
these portals and i dont have access to these states
and i cant access the parent container css from the
SelectFilterPlugin .... Because it will be difficult to differentiate
and also i had to add here because we need less space in case of
VerticalFormItem and HorizontalOverFlowitem & we have a bit more space in case
of horizontal list ... and i can only have the context from here
if we have Horizontal , HorizontalOverflow and VerticalForm item
Trying to do it from SelectFilterPlugin might require a lot of hacks and
unclean code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
