kasiazjc commented on PR #33054: URL: https://github.com/apache/superset/pull/33054#issuecomment-2796643186
> @kasiazjc I am testing the functionality and I am agreeing with @michael-s-molina on the part where this seems a duplicate of inverse selection as currently there are no clear boundaries between the two. Should the "dynamic" setting be a sub-setting of the "inverse selection"? > > Another option would be to make "inverse selection" dynamic and set to true by default for backward compatibility. Curious to hear more feedback. I like the idea of dynamic setting being the sub-setting of inverse selection. Good point! This should show up after the inverse selection checkbox is selected as in other cases - probably "add dynamic inverse selection". @michael-s-molina - as @geido mentioned the idea was to add a dynamic way of letting the users choose between including/excluding the values, because current setting is pretty much buried deep into modal and only admins can change it. We found that sometimes, depending on the use case, it would be easier for normal users to switch it on the spot, so that they can use filtering more easily In terms of design - I can see how it takes up a lot of space, especially in horizontal filter bar, so let me share the second proposal that I had before - this could work better. As a first select you would choose "is" or "is not" and later on you would have normal select. Thoughts? <img width="334" alt="image" src="https://github.com/user-attachments/assets/ccaef312-e06f-47aa-97b4-bcb9a9bbfcc7"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
