michael-s-molina commented on PR #33054: URL: https://github.com/apache/superset/pull/33054#issuecomment-2801485509
@kasiazjc I like your solution. The only change I would do is to remove the `show dynamic inverse selection option in the dashboard` and always enable that feature. It seems nice to always have a quick way of changing between IN and NOT IN in the filters and I want to avoid more complexity that needed. We just need to make sure that if `Inverse selection` is selected, the NOT IN is displayed by default. You all probably already know this but I just want to say anyway. The difference between the `Inverse selection` checkbox in the edit modal and the quick action to alternate between in/not in is that the former is saved and shared between all dashboard users and the latter is just a transient thing that is not saved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
