amaannawab923 commented on PR #33054: URL: https://github.com/apache/superset/pull/33054#issuecomment-2798783378
> > we found that users sometimes would prefer using excluding in terms of including values and it's not easily accessible > > I agree the user need is pretty clear. > > I think @amaannawab923 proposal makes sense: > > > Enable Dynamic Inverse selection which makes the checkbox of exclude filter values appear > > Keep true by default > > Toggling it will basically go back & forth to NOT IN and IN operator > > In this context, my observations would be: > > * Do we really need the `Enable Dynamic Inverse selection` or should we always present the checkbox in the filter so users can dynamically change between IN / NOT IN? > * We also need to think about how to migrate existing filters that currently have `Inverse selection` checked. Do we really `Enable Dynamic Inverse selection` or should we always present the checkbox .... thats something to discuss about , if it always appears within the native filter , it wont be much of an issue i guess , since its not interrupting the ui at all About migrating the existing filter , we can presume that someone has enabled inverse selection because they want to have the NOT IN operator ... in those cases ... We can use the inverse selection field from the form data of existing native filter to keep the Exclude filter values as True... as the existing native filters with inverse selection will work the way they expect but point number 1 needs to be discussed , do we really need it configurable or are we ok with it appearing always awaiting for feedback @michael-s-molina @geido -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
