eye-gu commented on PR #7395: URL: https://github.com/apache/shenyu/pull/7395#issuecomment-5929984423
> Thanks for fixing the three failing verifications. I noticed the two transaction-callback tests below still verify the 2-arg overload with `never()` (`DataChangedEventDispatcherTest.java` around lines 386 and 405). Since the dispatcher invokes the 3-arg overload, those checks can pass vacuously even if that listener is called. Could we align them to `onPluginChanged(anyList(), any(), any())` as well? That would make the no-dispatch assertions meaningful and matches the same overload issue described in #7393. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
