anaylab opened a new pull request, #663: URL: https://github.com/apache/shenyu-dashboard/pull/663
## What On the (dev-only) `/exception/trigger` page, `isloading` was tracked in local component state: set to `true` on click, but never reset, so the spinner ran forever. Separately, the `error` model's `trigger` reducer dropped the `isloading` field from state entirely. ## Fix Rather than patch the local `setState`/reset logic, this switches the component to the `loading.effects["error/query"]` pattern already used throughout the codebase (`GlobalHeader`, `BasicLayout`, most `System/*` pages, etc.). The `dva-loading` plugin tracks this automatically and resets it when the effect settles — including on failure — so the spinner can't get stuck the way it could with the manual flag. Also removed the `isloading` field from `models/error.js`'s state, since it's no longer read anywhere (it wasn't actually wired to the component before either — the component used its own local state). ## Testing - `npx eslint` on both changed files: clean. - Full `jest` suite: 32/32 passing. Closes #653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
