ppkarwasz commented on PR #4234: URL: https://github.com/apache/logging-log4j2/pull/4234#issuecomment-6363893368
> Hi @ppkarwasz, could you share your thoughts on the proposed fallback behavior for unsupported compression levels? Is there anything else you’d like me to clarify before I proceed with the implementation? Thanks! Regarding the fallback behavior, it looks like a good idea, although we could probably validate the value sooner, when `RolloverStrategy` is instantiated and warn the user only once. For example we could expose `resolveCompressionLevel` in `FileExtension` Regarding the mapping of `-1` and `0`: I don't see any need to provide a coherent set of compression levels. Let's just use the native levels of each compressor (which for `zstd` will allow for negative values too). If the user does **not** specify a compression level explicitly, we could use some marker value that is **not** a valid compression level for any algorithm. `Integer.MIN_VALUE` seems like a good candidate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
