ramanathan1504 commented on code in PR #4234:
URL: https://github.com/apache/logging-log4j2/pull/4234#discussion_r4215774096
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/GzCompressAction.java:
##########
@@ -142,29 +140,11 @@ public static boolean execute(
final File source, final File destination, final boolean
deleteSource, final int compressionLevel)
throws IOException {
checkCompressionLevel(compressionLevel);
Review Comment:
The static `execute` checks the level, but the constructor calls
`checkCompressionLevel` too, and that runs while the rollover is being built.
With `compressionLevel="10"` and a `.gz` pattern the rename never happens and
the event is dropped. Can this class move onto `AbstractCompressAction` so the
check only runs in `execute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
