katstack commented on PR #4234: URL: https://github.com/apache/logging-log4j2/pull/4234#issuecomment-6045463084
Before I make another code change, could we agree on the semantics for unsupported compressionLevel values? I would prefer to avoid format-specific coercions. -1 would remain the Log4j sentinel for selecting the format-specific default, supported values would be passed through, and unsupported values would fall back to the format-specific default with a warning from the asynchronous compression step. Zstd would be the only explicit mapping: its native -1 represents a fast-compression level, while Log4j uses -1 for an unspecified level, so Log4j's -1 needs to map to the Zstd default. With this approach, BZip2 level 0 would not be coerced to level 1; it would be treated as unsupported and fall back to BZip2's default level (9). Does that match the intended contract for the shared compressionLevel attribute? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
