rpuch commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2822460952
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/command/UpdateAllCommand.java:
##########
@@ -20,32 +20,20 @@
import java.util.HashMap;
import java.util.Map;
import java.util.UUID;
-import org.apache.ignite.internal.hlc.HybridTimestamp;
-import org.apache.ignite.internal.network.annotations.PropertyName;
import org.apache.ignite.internal.network.annotations.Transferable;
import
org.apache.ignite.internal.partition.replicator.network.PartitionReplicationMessageGroup;
import org.apache.ignite.internal.partition.replicator.network.TimedBinaryRow;
-import org.apache.ignite.internal.replicator.message.ReplicationGroupIdMessage;
import org.apache.ignite.internal.util.CollectionUtils;
-import org.jetbrains.annotations.Nullable;
/**
* State machine command for updating a batch of entries.
*
* <p>This command is replaced with {@link UpdateAllCommandV2} and only exists
in the source code for backward compatibility.</p>
*/
@Transferable(PartitionReplicationMessageGroup.Commands.UPDATE_ALL_V1)
-public interface UpdateAllCommand extends PartitionCommand {
- @PropertyName("tablePartitionId")
- ReplicationGroupIdMessage commitPartitionId();
-
+public interface UpdateAllCommand extends UpdateCommandBase {
Review Comment:
Command is built on the primary and the validator gets executed on the
leader; those are not necessarily colocated, so applying your suggestion
literally doesn't seem to be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
