rpuch commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2831688174
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/MetadataSufficiency.java:
##########
@@ -18,12 +18,14 @@
package org.apache.ignite.internal.table.distributed.schema;
import org.apache.ignite.internal.catalog.CatalogService;
+import org.apache.ignite.internal.hlc.HybridTimestamp;
+import org.apache.ignite.internal.schema.SchemaSyncService;
/**
- * Logic that allows to determine whether the logcal Catalog version is
sufficient.
+ * Logic that allows to determine whether the local schema metadata is
sufficient.
*/
-public class CatalogVersionSufficiency {
- private CatalogVersionSufficiency() {
+public class MetadataSufficiency {
Review Comment:
I think it will as the method name explains the intent well, but the
implementation is a bit less clear, AND it can change in the future. Also, it's
useful to see that the fact that this code is identical in 2 places is not just
a coincidence. And it's easier to forget to change the code in another place if
you inline even this one line.
On the other hand, it's not a problem to have a small class (with just one
line of code) if it has value and its role is well defined. I believe that it
is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
