denis-chudov commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2816408082
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -1743,16 +1745,21 @@ private void executeApplyingTasks(final
List<LogEntryAndClosure> tasks) {
}
continue;
}
+
+ // To prevent safe timestamp values from becoming stale, we
must assign them under a valid leader lock.
+ safeTs = tryAssignSafeTimestamp(task, safeTs);
+
+ if (rejectCommandIfSafeTimeIsNotAcceptable(safeTs, task)) {
Review Comment:
are these entries retried?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2436,6 +2439,19 @@ private CompletableFuture<Object>
applyCmdWithExceptionHandling(Command cmd) {
return raftCommandApplicator.applyCommandWithExceptionHandling(cmd);
}
+ private static CommandApplicationResult
throwIfFullTxCommitSchemaValidationFailedInRaft(CommandApplicationResult res,
Throwable ex) {
Review Comment:
```suggestion
private static CommandApplicationResult
throwIfFullTxCommitSchemaValidationFailedDuringReplication(CommandApplicationResult
res, Throwable ex) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
