ascherbakoff commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2831903293
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/error/RaftError.java:
##########
@@ -240,7 +240,13 @@ public enum RaftError {
/**
* Permission denied
*/
- EACCES(1016);
+ EACCES(1016),
+
+ /**
+ * Rejected by user logic. If ActionRequest gets such a response, the
corresponding command has not been either saved to log or applied
+ * on any node; also, the Raft client should not retry the same
ActionRequest attempt as it will never succeed.
+ */
+ EREJECTED_BY_USER_LOGIC(20000);
Review Comment:
```suggestion
EREJECTED_BY_VALIDATOR(20000);
```
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/schemacompat/CompatValidationResult.java:
##########
@@ -154,4 +156,25 @@ public String details() {
return details;
}
+
+ /**
+ * Returns error message corresponding to validation failure. Should only
be called for a failed validation result, otherwise an
+ * assertion error may be thrown.
+ */
+ public String validationFailedMessage() {
Review Comment:
Should we instead provide the exception itself:
`public Exception validationException()`
This implies better incapsulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
