keith-turner commented on code in PR #5240:
URL: https://github.com/apache/accumulo/pull/5240#discussion_r1909187277
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -292,26 +292,26 @@ public TabletFileCq(Path path, Range range) {
}
static class TabletFileCqMetadataGson {
- private String path;
- private byte[] startRow;
- private byte[] endRow;
+ protected String metadataEntry;
+ protected String path;
+ protected byte[] startRow;
+ protected byte[] endRow;
Review Comment:
After seeing this test failure I am starting to think that my assumption in
#5060 that escaping could be removed is flawed because it seems to create a
contradiction. The compaction metadata must maintain he exact data from the
metadata table `file` column qual so that it can delete it if misnormalized.
If trying to prevent escaping in the compaction metadata causes the data to be
normalized prior to serilization into compaction metadata, then it would no
longer exactly match what is in the `file` column qualifier which could cause
updates to fail or use the wrong key.
So the contradiction w/ #5060 is
1. The compaction metadata must maintain the exact column qualifier that is
in the `file` qualifier
2. Attempting to avoid escaping in the compaction metadata is a
transformation of the data.
So when transforming the data in any way then can no longer be sure about
maintaining the exact data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
