dlmarion commented on code in PR #5240:
URL: https://github.com/apache/accumulo/pull/5240#discussion_r1909175718
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -292,26 +292,26 @@ public TabletFileCq(Path path, Range range) {
}
static class TabletFileCqMetadataGson {
- private String path;
- private byte[] startRow;
- private byte[] endRow;
+ protected String metadataEntry;
+ protected String path;
+ protected byte[] startRow;
+ protected byte[] endRow;
Review Comment:
Looks like they are needed by the TabletFileCq object. Removing them would
cause an even bigger rewrite.
Update: I'm not even sure what `TabletFileCq` is used for. It's been hard to
wrap my head around this as there appears to be two different serializations of
this information. This is kind of a mess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
