cshannon commented on code in PR #5240:
URL: https://github.com/apache/accumulo/pull/5240#discussion_r1909119019
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -236,7 +236,7 @@ private static String serialize(TabletFileCq tabletFileCq) {
* returned as an empty byte array
**/
- private static byte[] encodeRow(final Key key) {
+ protected static byte[] encodeRow(final Key key) {
Review Comment:
You might want to get rid of protected and just make it package scope so it
matches the same scope as TableFileCqMetadataGson
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -252,7 +252,7 @@ private static byte[] encodeRow(final Key key) {
return new byte[0];
}
- private static Text decodeRow(byte[] serialized) {
+ protected static Text decodeRow(byte[] serialized) {
Review Comment:
Same comment here about removing protected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
