cshannon commented on code in PR #5240:
URL: https://github.com/apache/accumulo/pull/5240#discussion_r1909188951
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -292,26 +292,26 @@ public TabletFileCq(Path path, Range range) {
}
static class TabletFileCqMetadataGson {
- private String path;
- private byte[] startRow;
- private byte[] endRow;
+ protected String metadataEntry;
+ protected String path;
+ protected byte[] startRow;
+ protected byte[] endRow;
Review Comment:
The point of TabletFileCq is the in memory representation of the serialized
data. It contains Range and the Path which are the two separate pieces for
StoredTabletFile and is what is used everywhere in the code. It used to just be
a path and now we have a range.
TabletFileCqMetadataGson is supposed to be the serialized version of that.
We have this pattern laying around in several spots where we have a gson
version of an object. You obviously can't just write the Range object out by
default so we split it out into the start row and end row of the range and the
path as a string as json. Then that gets read back into TabletFileCq and used
by StoredTabletFile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
