On Tue, 31 Mar 2026 18:53:32 GMT, Marcono1234 <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply suggestions from code review >> >> Co-authored-by: Marcono1234 <[email protected]> > > test/jdk/java/net/DatagramSocket/SendReceiveMaxSize.java line 176: > >> 174: >> 175: if (exception != null) { >> 176: Exception ex = Assertions.assertThrows(IOE, () -> >> sender.send(sendPkt)); > > Should this actually test for the specified exception class? (though > currently it seems that is always `IOE`) > > Suggestion: > > Exception ex = Assertions.assertThrows(exception, () -> > sender.send(sendPkt)); Just as side note; I hope applying my suggestions (and implicitly adding `Co-authored-by: Marcono1234`) is not causing any issues. Otherwise feel free to omit that `Co-authored-by` for me. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30502#discussion_r3022062949
