On Tue, 31 Mar 2026 06:31:36 GMT, Alan Bateman <[email protected]> wrote:
>> May I get a review for this change that converts `java/net/DatagramSocket`
>> TestNG tests to use JUnit.
>>
>> Some of these tests now take advantage from the fact that Closeable
>> arguments passed to a ParameterizedTest are automatically closed by JUnit.
>
> test/jdk/java/net/DatagramSocket/DatagramTimeout.java line 57:
>
>> 55: public static List<DatagramSocket> sockets() throws IOException {
>> 56: // Closeable arguments passed to a ParameterizedTest are
>> automatically
>> 57: // closed by JUnit
>
> I personally don't like to rely on that feature, only because it's a bit too
> magic.
I was reluctant to type the same, thankfully Alan took the lead. 😇
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30502#discussion_r3014237892
