> May I get a review for this change that converts `java/net/DatagramSocket` > TestNG tests to use JUnit. > > Some of these tests now take advantage from the fact that Closeable arguments > passed to a ParameterizedTest are automatically closed by JUnit.
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'master' into junit-ds-8381359 - Review feedback - Apply suggestions from code review Co-authored-by: Marcono1234 <[email protected]> - Apply suggestion from @Marcono1234 Co-authored-by: Marcono1234 <[email protected]> - 8381359: Refactor java/net/DatagramSocket TestNG tests to use JUnit ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30502/files - new: https://git.openjdk.org/jdk/pull/30502/files/069e5ed2..80c12500 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30502&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30502&range=03-04 Stats: 10719 lines in 318 files changed: 5601 ins; 1797 del; 3321 mod Patch: https://git.openjdk.org/jdk/pull/30502.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30502/head:pull/30502 PR: https://git.openjdk.org/jdk/pull/30502
