On Mon, 30 Mar 2026 19:15:50 GMT, Volkan Yazici <[email protected]> wrote:
>> May I get a review for this change that converts `java/net/DatagramSocket`
>> TestNG tests to use JUnit.
>>
>> Some of these tests now take advantage from the fact that Closeable
>> arguments passed to a ParameterizedTest are automatically closed by JUnit.
>
> test/jdk/java/net/DatagramSocket/ConnectPortZero.java line 62:
>
>> 60: }
>> 61:
>> 62: public static List<Arguments> testCases() throws IOException {
>
> You don't need to switch from `Object[][]` to `List<Arguments>`, both would
> work, FYI.
>
> [Note that this comment applies to more places.]
I know. I would have used `List<Arguments>` rather than `Object[][]` if I had
written this directly for JUnit and since I was changing this part I made the
switch. I have kept `Object[][]` in other places though.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30502#discussion_r3016126288
