https://github.com/kendalharland created 
https://github.com/llvm/llvm-project/pull/96687

The strings this test is using seem to consistently fail to match against the 
expected values when built & run targeting Windows amd64. This PR updates them 
to the expected values.

>From 2e3ac00255e5608ff39bf9cd69f1fb4590d2b90d Mon Sep 17 00:00:00 2001
From: kendal <kendal@thebrowser.company>
Date: Mon, 24 Jun 2024 14:01:31 -0700
Subject: [PATCH] Fix test assertions in TestDAP_stepInTargets.py

---
 .../tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py 
b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
index 6296f6554d07e..cc53954885cdf 100644
--- a/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
+++ b/lldb/test/API/tools/lldb-dap/stepInTargets/TestDAP_stepInTargets.py
@@ -55,14 +55,14 @@ def test_basic(self):
         self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets")
 
         # Verify the target names are correct.
-        self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()")
-        self.assertEqual(step_in_targets[1]["label"], "bar2()", "expect 
bar2()")
+        self.assertEqual(step_in_targets[0]["label"], "int bar2(void)", 
"expect bar2()")
+        self.assertEqual(step_in_targets[1]["label"], "int bar(void)", "expect 
bar()")
         self.assertEqual(
-            step_in_targets[2]["label"], "foo(int, int)", "expect foo(int, 
int)"
+            step_in_targets[2]["label"], "int foo(int, int)", "expect foo(int, 
int)"
         )
 
         # Choose to step into second target and verify that we are in bar2()
         self.stepIn(threadId=tid, targetId=step_in_targets[1]["id"], 
waitForStop=True)
         leaf_frame = self.dap_server.get_stackFrame()
         self.assertIsNotNone(leaf_frame, "expect a leaf frame")
-        self.assertEqual(leaf_frame["name"], "bar2()")
+        self.assertEqual(leaf_frame["name"], "int bar2(void)")

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to