jankratochvil planned changes to this revision.
jankratochvil added a comment.

In D63540#1805967 <https://reviews.llvm.org/D63540#1805967>, @labath wrote:

> Passing different sort objects to different sort invocations could cause 
> changes done by one Sort call to be undone by further Symtab additions 
> (and/or trigger assertions in the `IsSorted` function). It seems to me that 
> the sort order should be a property of the RangeMap object, set when the 
> object is created, similar to how std::map and friends do this thing...


I did not like it much myself but I did not realize when it could really cause 
a problem, thanks for the example. I will try to find some way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to