jankratochvil added a comment. In D63540#1809725 <https://reviews.llvm.org/D63540#1809725>, @labath wrote:
> - make the RangeMap constructor take a `const Compare &` instead of a > template pack. The std containers do the same, and I don't see a reason to > diverge.. Done. I have mistaken it as optimization but that does not apply in this case. > - make Compare operate only on the "data" field of the map. The RangeMap > methods assume the entries are sorted in a certain way, so changing that in > the comparator does not seem useful. The std::sort call can take a lambda or > something to first compare the ranges and then the data fields... > > It might also be nice to split this off into a separate patch with a unit > test and all... Done in D72460 <https://reviews.llvm.org/D72460>. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
