jankratochvil marked an inline comment as done. jankratochvil added a comment.
In D63540#1791017 <https://reviews.llvm.org/D63540#1791017>, @labath wrote: > Defining some sort of a preference based on symbol type seems like a good > idea, but I don't think this is a good way to implement it. If I read this > patch correctly, then this for example means that the "less global" symbols > will not be reported through the Symtab::ForEachSymbolContainingFileAddress > API, which seems like a bad thing. Is this update OK now? Thanks for the review. > I'm also not happy that this is supposed to be a replacement for the size > setting patch, as I believe (and I think we've agreed on that while reviewing > the original patch) that *not* fiddling with the sizes of those symbols is a > good thing. I agree although I think this new "bindings priority" patch is also a good thing on its own and it is easier to implement. IMHO we can then continue with the "sizeless" patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
