jankratochvil planned changes to this revision. jankratochvil added a comment.
In D63540#1791017 <https://reviews.llvm.org/D63540#1791017>, @labath wrote: > then this for example means that the "less global" symbols will not be > reported through the Symtab::ForEachSymbolContainingFileAddress API, which > seems like a bad thing. I agree, I was not aware of this function. Still sure the prioritization could be moved to `Symtab::FindSymbolContainingFileAddress`. > I'm also not happy that this is supposed to be a replacement for the size > setting patch, as I believe (and I think we've agreed on that while reviewing > the original patch) that *not* fiddling with the sizes of those symbols is a > good thing. I don't think reverting a patch that has been sitting in the tree > for several months because it "breaks expression evaluation" is a good idea, OK, I will try to recheck how to fix the arm32 issue with the previous patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
