clayborg added inline comments.
================
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:394
+ if (name_str.find_first_of("[]?*.-+\\") != std::string::npos)
+ FindTypesByRegex(RegularExpression(name_str), max_matches, types);
else
----------------
You should make the RegularExpression object first and then check for errors.
If there are errors, the type lookup should happen by normal name. This is
again why I don't like us sniffing for a regular expression. If there is an
error, like when trying to lookup "char*" as mentioned by Aaron, would you
expect to see an error message saying "char*" isn't a valid regex? Then the
user thinks that the type lookup always takes a regular expression which is not
the case, just something the PDB plugin added for some reason. I do believe
part of this patch should be adding the
lldb_private::SymbolFile::FindTypesByRegex(...) to the base class and fixing
this issue by removing the regex sniffing code since it is fragile at best (how
are we doing to lookup a template type without triggering the regex issues?).
Repository:
rL LLVM
https://reviews.llvm.org/D41086
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
