That seems reasonable. Seems Aaron ran into this not because he was trying to do a regex search, but because he *wasnt* trying to do a regex search. So if he doesn’t have immediate need for a regex search, and if it’s not tested anyway, removing it seems fine On Wed, Dec 20, 2017 at 10:49 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote:
> clayborg added a comment. > > If you load a exe file that has a PDB file, people can currently run: > > (lldb) type lookup "char*" > > If no testing is using the regular expression stuff, then just pull it > out. Do we have unit tests that depend on this working? If not, lets just > pull it out from the SymbolFilePDB::FindTypes() and we can leave the fix in > that uses the RegularExpression class so it won't crash in the future? > > > Repository: > rL LLVM > > https://reviews.llvm.org/D41086 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
