The url provided times out but my guess is these two unit tests are what are failing.
lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp - TEST_F(SymbolFilePDBTests, TestRegexNameMatch) - TEST_F(SymbolFilePDBTests, TestMaxMatches) The first one is testing regex name matching which was decided in this code review to not support right now. The second one is using a regex to return all symbol names and checking that the number of results returned by FindTypes() is consistent. The first one can be updated to use FindTypesByRegex() if the API is made public as Greg recommends. The second needs more thought. On Fri, Dec 22, 2017 at 7:54 AM, Greg Clayton <clayb...@gmail.com> wrote: > We should fix the test case to not require regex, or add > SymbolFile::FindTypesByRegex(...) and pass that through to public API if > needed. Not sure where the test is failing (gtest, or public API test). > >> On Dec 22, 2017, at 2:01 AM, Pavel Labath via Phabricator >> <revi...@reviews.llvm.org> wrote: >> >> labath added a comment. >> >> This is making the windows unit tests fail: >> http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7378/steps/run%20unit%20tests/logs/stdio. >> If I understand correctly, this changes FindTypes to **not** search by >> regex. >> If that's the case, then the `SymbolFilePDBTests::TestRegexNameMatch` needs >> to be updated to not expect that `.*` will find a match. >> Also, while technically not failing, the >> `SymbolFilePDBTests::TestMaxMatches` also looks weird in this new world, >> and probably needs updating. >> >> Could you look into those? >> >> >> Repository: >> rL LLVM >> >> https://reviews.llvm.org/D41086 >> >> >> > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
