tfiala added a comment.

> Again, if we switch the parser over to use an llvm::StringRef then this make 
> sense, otherwise it doesn't.


I don't want to conflate this change with switching the parser over to a string 
ref.  The only reason I changed the entry to a const char* was to avoid 
creating a couple unnecessary temporaries.

We can consider the parser conversion a separate logical change that can be 
done independently.


https://reviews.llvm.org/D23884



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to