tfiala added inline comments.
================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:113
@@ -105,4 +112,3 @@
case 'J':
- // Asynchronous JSON packet, destined for a
- // StructuredDataPlugin.
{
+ // Verify this J packet is a JSON-async: packet.
----------------
labath wrote:
> I'd like to move this code to a separate function. The main job of
> `SendContinuePacketAndWaitForResponse` is dealing with the thread
> synchronization issues, which is tricky enough without having json parsing in
> the middle of it.
Sure, sounds like a good change.
================
Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:371
@@ +370,3 @@
+ ASSERT_EQ("T01", response.GetStringRef());
+ ASSERT_EQ(fix.delegate.structured_data_entries.size(), 1);
+
----------------
labath wrote:
> Please put the "expected" values first (`ASSERT_NE(expected, actual)`).
> Otherwise the error message will come out wrong when the comparison fails.
> The same issue is present in a number of other checks.
Okay. That's somewhat unfortunate that Python unittest's messages are geared
for the reverse:
http://bugs.python.org/issue10573
I will reverse these, thanks for catching that!
https://reviews.llvm.org/D23884
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
