----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103264/#review8538 -----------------------------------------------------------
kmymoney/mymoney/mymoneyfile.h <http://git.reviewboard.kde.org/r/103264/#comment7237> Now that we have a new member in MyMoneyFile, please add testcase(s) to MyMoneyFileTest that prove that the code works as expected. See below for testcases I could imagine. kmymoney/mymoney/mymoneyfile.h <http://git.reviewboard.kde.org/r/103264/#comment7240> Mention how method behaves in case no online balance is available for the account. kmymoney/mymoney/mymoneyfile.h <http://git.reviewboard.kde.org/r/103264/#comment7239> make that a const method by adding the word 'const' between ')' and ';'. kmymoney/mymoney/mymoneyfile.cpp <http://git.reviewboard.kde.org/r/103264/#comment7238> Ooops, this won't work. You need to check if you have an online balance and in case you don't, return false. Add a test cases for a) no online balance available b) online balance matches c) online balance does not match - Thomas Baumgart On Nov. 27, 2011, 4:32 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103264/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2011, 4:32 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > Highlighting of online statement balance with red background and > highlighted text if file balance and online balance are different. > (This patch was put together from Thomas' and Cristian's advice on ML) > > > This addresses bug 287494. > http://bugs.kde.org/show_bug.cgi?id=287494 > > > Diffs > ----- > > kmymoney/mymoney/mymoneyfile.h d44e2ea > kmymoney/mymoney/mymoneyfile.cpp f573f9a > kmymoney/widgets/register.h 8cd1a32 > kmymoney/widgets/register.cpp 39d991c > > Diff: http://git.reviewboard.kde.org/r/103264/diff/diff > > > Testing > ------- > > Yes > > > Screenshots > ----------- > > small snapshot showing the highlighted group marker > http://git.reviewboard.kde.org/r/103264/s/345/ > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
