----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103264/#review8502 -----------------------------------------------------------
kmymoney/widgets/register.cpp <http://git.reviewboard.kde.org/r/103264/#comment7214> Although in general I agree, the detection logic should not be placed inside the MyMoneyAccount object. It has no reference of the MyMoneyFile object (and should not get it). Something like a "MyMoneyFile::checkMatchingOnlineBalance(const MyMoneyAccount& account) const" would be much better. kmymoney/widgets/register.cpp <http://git.reviewboard.kde.org/r/103264/#comment7215> Shouldn't be a problem here, because it is checked that lastImportedTransactionDate is set which is only done when you receive some sort of online balance. I am not sure how this behaves if you remove the mapping though and still have a lastImportedTransactionDate. Should not interfere, because the balance for that date should still be correct. - Thomas Baumgart On Nov. 27, 2011, 1:16 a.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103264/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2011, 1:16 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > Highlighting of online statement balance with red background and > highlighted text if file balance and online balance are different. > (This patch was put together from Thomas' and Cristian's advice on ML) > > > Diffs > ----- > > kmymoney/widgets/register.h 8cd1a328fb690fad015a0de5943c984b7e7deca8 > kmymoney/widgets/register.cpp 39d991c30d531154fd2651a52ab2b6a199b92b32 > > Diff: http://git.reviewboard.kde.org/r/103264/diff/diff > > > Testing > ------- > > Yes > > > Screenshots > ----------- > > small snapshot showing the highlighted group marker > http://git.reviewboard.kde.org/r/103264/s/345/ > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
