> On Nov. 27, 2011, 1:54 a.m., Alvaro Soliverez wrote:
> > kmymoney/widgets/register.h, line 162
> > <http://git.reviewboard.kde.org/r/103264/diff/1/?file=42242#file42242line162>
> >
> > The name is ambiguous.
> > Perhaps something like isConsistentWithOnline might more descriptive
The question is for me here, whether the already existing member function
isErronous() was actually meant to be used for a purpose like this?
Do we need the existing isErronous()? (Not only because of the wrong spelling,
in general I mean, what else is it's purpose?) {AND there are two other classes
with the same isErronous() around...}
Apart from that I am of course willing to rename it according to your
suggestion.
- Marko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103264/#review8499
-----------------------------------------------------------
On Nov. 27, 2011, 1:16 a.m., Marko Käning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103264/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2011, 1:16 a.m.)
>
>
> Review request for KMymoney.
>
>
> Description
> -------
>
> Highlighting of online statement balance with red background and
> highlighted text if file balance and online balance are different.
> (This patch was put together from Thomas' and Cristian's advice on ML)
>
>
> Diffs
> -----
>
> kmymoney/widgets/register.h 8cd1a328fb690fad015a0de5943c984b7e7deca8
> kmymoney/widgets/register.cpp 39d991c30d531154fd2651a52ab2b6a199b92b32
>
> Diff: http://git.reviewboard.kde.org/r/103264/diff/diff
>
>
> Testing
> -------
>
> Yes
>
>
> Screenshots
> -----------
>
> small snapshot showing the highlighted group marker
> http://git.reviewboard.kde.org/r/103264/s/345/
>
>
> Thanks,
>
> Marko Käning
>
>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
