https://bugs.kde.org/show_bug.cgi?id=485927

--- Comment #44 from Brandon Wright <bear...@gmail.com> ---
(In reply to David Edmundson from comment #43)
> >The presumably sanctioned alternative is to inherit QAnimationDriver and use 
> >the install() method, which replaces the global animation driver.
> 
> Yeah, that's what I had in #24, though it seemed that got lost in the next
> comment. 
> 
> I rebased it and putting a direct myself this time :)
> https://invent.kde.org/plasma/kwin/-/commits/work/d_ed/animation_driver
> 
> ---
> 
> I'll test your patch too and see if that is more noticeable for me.
Yeah, I only saw the duration patch before. I tried the animation driver one
and it causes the animation to not update at all. Because it's installed
globally, I'd guess a subclassed animation driver would need a lot of
duplicated boilerplate so it reacts similarly enough to QDefaultAnimationTimer
to not break things. QUnifiedTimer::updateAnimationTimers is essentially
exactly what we needed. It doesn't have any side-effects because it just
triggers an early update and then lets the timer get on with its business. It's
unfortunate that it's a private API.

I'm also wondering whether other components using QtQuick would need changes.
Are they using the full render loop or doing a partially custom thing like
kwin?.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to