0xffff-zhiyan commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2747600331
##########
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##########
@@ -148,10 +152,13 @@ public MetadataShell(
private void initializeWithSnapshotFileReader() throws Exception {
this.fileLock = takeDirectoryLockIfExists(parentParent(new
File(snapshotPath)));
+ DynamicConfigValidator dynamicConfigValidator = new
ControllerConfigurationValidator(new KafkaConfig(new Properties(), false));
+
this.loader = new MetadataLoader.Builder().
setFaultHandler(faultHandler).
setNodeId(-1).
setHighWaterMarkAccessor(() ->
snapshotFileReader.highWaterMark()).
+ setConfigValidator(dynamicConfigValidator).
Review Comment:
`MetadataLoader` is in the `metadata` module, while
`ControllerConfigurationValidator` is in the `core` module. Making
`ControllerConfigurationValidator` the default would create a circular
dependency violation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
