0xffff-zhiyan commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2771128430
##########
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala:
##########
@@ -44,7 +47,33 @@ import scala.collection.mutable
* in the same RPC, BROKER_LOGGER is not really a dynamic configuration in the
same sense
* as the others. It is not persisted to the metadata log.
*/
-class ControllerConfigurationValidator(kafkaConfig: KafkaConfig) extends
ConfigurationValidator {
+class ControllerConfigurationValidator(private val kafkaConfig: KafkaConfig)
Review Comment:
Because some classes already use `ControllerConfigurationValidator`, reusing
it as `SupportedConfigChecker` can avoid passing an additional parameter. And
in some places like `ControllerServer`, we need both `ConfigurationValidator`
and `SupportedConfigChecker` which may cause some confusion like why do we need
two validators? what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
