jsancio commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2742898422
##########
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##########
@@ -83,7 +92,12 @@ public MetadataDelta build() {
private DelegationTokenDelta delegationTokenDelta = null;
public MetadataDelta(MetadataImage image) {
+ this(image, null);
+ }
Review Comment:
Let's try to avoid having overloaded constructors or function. I suggest
removing this constructor and maybe even making it private. Ideally, user
should be using the Builder for this type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
