0xffff-zhiyan commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2718557765
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -327,6 +338,13 @@ private ApiError validateAlterConfig(
Map<String, String> alteredConfigsForAlterConfigPolicyCheck = new
HashMap<>();
TimelineHashMap<String, String> existingConfigsSnapshot =
configData.get(configResource);
if (existingConfigsSnapshot != null) {
+ if (configValidator != null) {
+ for (String name : existingConfigsSnapshot.keySet()) {
+ if (!configValidator.isValidConfig(configResource.type(),
name)) {
+ existingConfigsSnapshot.remove(name);
Review Comment:
I think we still need to check existingConfigs because it's used for state
transition validation, not just validity checks. For example,
`LogConfig.validate()` needs the previous state to validate transitions like
disabling remote storage (checking if remote.log.delete.on.disable=true is set).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
