ahuang98 commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2714598781
##########
metadata/src/test/java/org/apache/kafka/image/ConfigurationsImageTest.java:
##########
@@ -162,6 +162,32 @@ public void testConfigurationDeltaWithoutFiltering() {
assertTrue(result.data().containsKey("baz"));
}
+ @Test
+ public void testConfigurationDeltaFinishSnapshotFiltersInvalidConfigs() {
Review Comment:
this test name makes it seem like the `finishSnapshot` call filters configs
when it's just the replay method that does. let's maybe rename this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
