ahuang98 commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2714589303
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -327,6 +338,13 @@ private ApiError validateAlterConfig(
Map<String, String> alteredConfigsForAlterConfigPolicyCheck = new
HashMap<>();
TimelineHashMap<String, String> existingConfigsSnapshot =
configData.get(configResource);
if (existingConfigsSnapshot != null) {
+ if (configValidator != null) {
+ for (String name : existingConfigsSnapshot.keySet()) {
+ if (!configValidator.isValidConfig(configResource.type(),
name)) {
+ existingConfigsSnapshot.remove(name);
Review Comment:
or, there might be an argument for why we should just avoid throwing errors
on existingConfigs when validating alter config requests to begin with.
(`ControllerConfigurationValidator#validate` is only called when validating
alter config requests - we can simply skip checking existingConfigs in that
method altogether if folks agree on this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
