chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2093848474
##########
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##########
@@ -52,8 +52,13 @@ class LogConfigTest {
assertTrue(LogConfig.configNames.asScala
.filter(config =>
!LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS.contains(config))
.forall { config =>
- val serverConfigOpt = LogConfig.serverConfigName(config)
- serverConfigOpt.isPresent && (serverConfigOpt.get != null)
+ // this internal config naming pattern is not as same as a default
pattern
+ if (config.equals(LogConfig.INTERNAL_SEGMENT_BYTES_CONFIG)) {
Review Comment:
I guess this change is related to the comment
(https://github.com/apache/kafka/pull/19371#discussion_r2091933863)
Maybe we can remove the test `ensureNoStaticInitializationOrderDependency`
and `CONFIGS_WITH_NO_SERVER_DEFAULTS`.
They were used to test the bug caused by the initialization order between
`KafkaConfig` and `LogConfig` (see
https://github.com/apache/kafka/commit/0ea540552a52b3265c48aacbb9790ea6e71431a5).
Fortunately, the dependence was gone when rewriting `LogConfig` by java (see
https://github.com/apache/kafka/commit/96d9710c17b34d4e80259f09845d21de66a5efaf)
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
